Skip to content

[release-4.15] OCPBUGS-62980: Update CNO reviewers/approvers #2817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2025
Merged

[release-4.15] OCPBUGS-62980: Update CNO reviewers/approvers #2817

merged 3 commits into from
Oct 14, 2025

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Oct 13, 2025

This is an automated cherry-pick of #2803

/assign pliurh

fedepaol and others added 3 commits October 13, 2025 10:37
@fedepaol
Owners: use aliases for core approvers / reviewers
7d4c008 
This allows to keep the list in a single place while reusing them also
in sub directories, where we might want to expand that list.

Signed-off-by: Federico Paolinelli <[email protected]>
(cherry picked from commit 6497b7d)
@jcaamano
Update CNO reviwers/approvers
c0af989 
Removing trozet as he left the company. Adding tssurya as team lead
replacement.

Adding pliurh as approver replacing dougbtv who will be eventually
removed after some soak period as he moved on to other unrelated
projects. pliurh has demonstrated extensive experience working on this
repository througout his work on sdn->ovnk different migration modes.

Added bpickard22 to help as a reviewer for multus related changes as a
replacement for dougbtv.

Adding the overall core network team as responsible to perform reviews.

Signed-off-by: Jaime Caamaño Ruiz <[email protected]>
(cherry picked from commit 1704438)
@pliurh
Remove fepan from the OWNERS_ALIASES file
2cfc62b 
CI bot verification blocks change to OWNERS_ALIASES as fepan is
not a member of the org.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 13, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 13, 2025

@openshift-cherrypick-robot: Jira Issue OCPBUGS-62055 has been cloned as Jira Issue OCPBUGS-62980. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-62980: Update CNO reviewers/approvers

In response to this:

This is an automated cherry-pick of #2803

/assign pliurh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-62055: Update CNO reviewers/approvers [release-4.15] OCPBUGS-62980: Update CNO reviewers/approvers Oct 13, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 13, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 13, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-62980, which is invalid:

  • expected dependent Jira Issue OCPBUGS-62055 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #2803

/assign pliurh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from kyrtapz and tssurya October 13, 2025 10:37
@kyrtapz
Copy link
Contributor

kyrtapz commented Oct 13, 2025

/lgtm
/verified bypass
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 13, 2025
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 13, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 13, 2025

@kyrtapz: The verified label has been added.

In response to this:

/lgtm
/verified bypass
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 2cfc62b link false /test security
ci/prow/4.15-upgrade-from-stable-4.14-e2e-aws-ovn-upgrade 2cfc62b link false /test 4.15-upgrade-from-stable-4.14-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pliurh
Copy link
Contributor

pliurh commented Oct 14, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 14, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 14, 2025

@pliurh: This pull request references Jira Issue OCPBUGS-62980, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-62055 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-62055 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit fa9184f into openshift:release-4.15 Oct 14, 2025
16 of 18 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 14, 2025

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-62980
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-62980 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

This is an automated cherry-pick of #2803

/assign pliurh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pliurh
Copy link
Contributor

pliurh commented Oct 17, 2025

/cherrypick release-4.14

@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Oct 17, 2025

@pliurh: #2817 failed to apply on top of branch "release-4.14":

Applying: Owners: use aliases for core approvers / reviewers
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
CONFLICT (add/add): Merge conflict in OWNERS_ALIASES
Auto-merging OWNERS_ALIASES
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Owners: use aliases for core approvers / reviewers

In response to this:

/cherrypick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyrtapz kyrtapz Awaiting requested review from kyrtapz

@tssurya tssurya Awaiting requested review from tssurya

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@mffiedler mffiedler

@eurijon eurijon

@pliurh pliurh

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@imatza-rh imatza-rh

@Meina-rh Meina-rh

@barbora137 barbora137

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.